Support progress descriptions when progress bars are disabled - #574
Draft
sapunyangkut wants to merge 1 commit into
Draft
Support progress descriptions when progress bars are disabled#574sapunyangkut wants to merge 1 commit into
sapunyangkut wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tqdm-compatible no-opset_descriptionmethod to_NoOpPBar.update, positional and keywordset_descriptioncalls, and silent output.Motivation
When progress display is disabled,
get_progress_barreturns_NoOpPBar. Callers using the commontqdm.set_descriptioninterface currently receive anAttributeError. This keeps the disabled path interface-compatible without rendering anything or adding a dependency.Validation
python -m tox -e py312-extras— 130 passedpython -m tox -e lint— all hooks passedpython -m build --no-isolation .— sdist and wheel built successfullyFixes #476
AI assistance disclosure
This contribution was prepared and validated with OpenAI Codex automation. The automation reproduced the failure on the current upstream commit, produced the two-file patch, and ran the checks listed above.