Merged
Conversation
mangalaman93
force-pushed
the
aman/v1
branch
from
561c3bd to
5349c03
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request moves v2 APIs from the v1 API package to consolidate the API structure. The PR removes duplicate API definitions and updates import references to use the main API package instead of the separate v2 package.
- Import references updated from
apiv2toapiin zero.go - Entire v2_test.go file removed
- Generated protobuf files updated with new API methods and unified API structure
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| zero.go | Updates import from apiv2 to api package and references to use unified API types |
| v2_test.go | Complete removal of v2-specific test file |
| protos/api/cc.go | Removes v2-specific connection helper function |
| protos/api/api_grpc.pb.go | Generated file with new v2 API methods added to main API service |
| protos/api/api.pb.go | Generated file with new message types and enums moved from v2 |
| protos/api.v2/api.v2_grpc.pb.go | Complete removal of v2-specific gRPC service definitions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mangalaman93
force-pushed
the
aman/v1
branch
2 times, most recently
from
1efa69f to
fda084b
Compare
mangalaman93
force-pushed
the
aman/v1
branch
from
fda084b to
d40e91d
Compare
| if err != nil { | ||
| return nil, fmt.Errorf("invalid namespace ID: %w", err) | ||
| } | ||
| opts = append(opts, WithNamespace(nsID)) |
Collaborator
There was a problem hiding this comment.
If a namespace is specified, but a username and password are not, should this not return an error?
mangalaman93
force-pushed
the
aman/v1
branch
from
d40e91d to
45efa66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.