fix(graphql): Exclude auxiliary types for @extends in Apollo Federation _service queries#9663
Open
matthewmcneely wants to merge 13 commits intomainfrom
Open
fix(graphql): Exclude auxiliary types for @extends in Apollo Federation _service queries#9663matthewmcneely wants to merge 13 commits intomainfrom
matthewmcneely wants to merge 13 commits intomainfrom
Conversation
github-actions
bot
added
area/testing
This comment has been minimized.
This comment has been minimized.
matthewmcneely
force-pushed
the
matthewmcneely/graphql-federation-issues
branch
2 times, most recently
from
48de07a to
9de2145
Compare
negated conjunction form is clearer than De Morgan for federation checks
matthewmcneely
force-pushed
the
matthewmcneely/graphql-federation-issues
branch
from
9de2145 to
b6272fe
Compare
xqqp
reviewed
Mar 20, 2026
Reflect the new behavior where auxiliary types (filters, orderables, mutations, aggregates) are no longer generated for @extends types in the Apollo service query output. This prevents conflicts when composing federated schemas.
mlwelles
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using Dgraph as Apollo Federation subgraphs, the
_servicequery returns auxiliary types (mutations, filters, inputs) for types marked with@extends. This causes schema composition conflicts in Apollo Rover because multiple subgraphs attempt to define the same auxiliary types for extended entities.For example, if subgraph A defines
type User @key(fields: "id")and subgraph B extends it withextend type User @key(fields: "id") { reviews: [Review] }, both subgraphs would generateUserPatch,UserFilter,AddUserInput, etc., causing Rover composition to fail.Fixes #9662
Changes
apolloServiceQuery && hasExtends(defn)TestApolloServiceQueryExcludesAuxiliaryTypesto verify exclusion behaviorChecklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.