Conversation
netroms
changed the title
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
* fix: expose sessionTimeout in system/info endpoint * fix: include server time in SESSION_EXPIRE cookie
Signed-off-by: Morten Svanaes <msvanaes@dhis2.org>
|
|
Instance deployed to https://dev.im.dhis2.org/pr-22950 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: the cookie part of this is duplicated by #23115
Summary
/api/requests instead of 302 redirect to login page. The old detection only checkedX-Requested-With: XMLHttpRequest(a jQuery convention that modernfetch()doesn't send), so SPA clients got broken redirects on session expiry.SESSION_EXPIREcookie so front-end SPAs can detect session expiry viadocument.cookiewithout intercepting response headers.