Introhsn #11
Open
Introhsn #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwenthey
reviewed
Jun 28, 2018
| margin:auto; | ||
| } | ||
|
|
||
| .photo { |
There was a problem hiding this comment.
还是和对大蓉儿一样的建议，尽量用独特的类名 “.hsn-photo” 或一个父类".hsn .photo" 去限制你的css生效的范围，我去看了一下大蓉儿的css，里面也有一个class叫photo，当大家的html整合在同一个文件之后，你们各自的.photo css会互相影响，导致混乱。
mrcfps
reviewed
Jun 28, 2018
| </head> | ||
|
|
||
| <body> | ||
| <div class="overall"> |
There was a problem hiding this comment.
其实我们并不需要 overall 这个 div，因为功能上和 body 是等价的
| @@ -0,0 +1,71 @@ | |||
|
|
|||
| .overall { | |||
pftom
reviewed
Jun 28, 2018
| margin:auto; | ||
| } | ||
|
|
||
| .photo { |
| height: 356.1px; | ||
| margin: auto; | ||
| margin-bottom: 124.9px; | ||
| object-fit: contain; |
There was a problem hiding this comment.
学姐我们这里还是严格要求代码规范。这行 object-fit 前面多了一个空格 ( )
| object-fit: contain; | ||
| } | ||
| .first { | ||
| width:854px; |
There was a problem hiding this comment.
还有这里 width: 854px;，中间也需要一个空格。
| border-style:solid; | ||
| border-color:black; | ||
| } | ||
| .second{ |
There was a problem hiding this comment.
这里也是，.second 和 { 之间也需要空格 ( )
| clear:both; | ||
| } | ||
| .content_sty{ | ||
| font-family: PingFangSC; |
There was a problem hiding this comment.
还有这里我们书写 css 属性时，每条属性应该一行，同时应该有两个空格的缩进。
eg:
.content_sty {
font-family: PingFangSC;
font-size: 18px;
}
dearonger
reviewed
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
界面整体写好，仍有一些小细节还未完善