Deprecate ensembling#373
Open
alkidbaci wants to merge 6 commits into
Open
Conversation
4 tasks
Co-authored-by: claude <claude@users.noreply.github.com>
Co-authored-by: claude <claude@users.noreply.github.com>
Contributor
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: sshivam95 <26580082+sshivam95@users.noreply.github.com>
Contributor
Resolved in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we have deprecated ensembling (#366) which includes the removal of the following classes:
ensemble.pymodule (contained theEnsembleKGE)TensorParallelclass removed as it was dependent only onEnsembleKGEThe code is updated to reflect these changes, e.g. updated conditions which considered
EnsembleKGEorTensorParallel.Some tests are also updated or removed
Note that this PR is requesting to merge to the branch imports-refactoring which on its own is an open PR to the branch develop.