Skip to content

Version 1.0#2

Merged
senid231 merged 5 commits into
masterfrom
version-1-0
Jun 8, 2026
Merged

Version 1.0#2
senid231 merged 5 commits into
masterfrom
version-1-0

Conversation

@senid231

@senid231 senid231 commented Jun 8, 2026

Copy link
Copy Markdown
Member
  • update rubocop
  • introduce Model and BulkUpdate classes, refactor Base class
  • improve testing, add github actions
  • add CHANGELOG.md
  • improve README.md and gemspec description

@senid231 senid231 requested a review from Copilot June 8, 2026 12:01
@senid231 senid231 self-assigned this Jun 8, 2026
@senid231 senid231 changed the title Version 1 0 Version 1.0 Jun 8, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread lib/pg_sql_caller/model.rb Fixed
Comment thread lib/pg_sql_caller/model.rb Dismissed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the gem for a 1.0.0 release by modernizing its supported Ruby/Rails versions, refactoring the core SQL API into an instantiable Model with a Base singleton facade, and adding a PostgreSQL-specific bulk update utility. It also expands documentation, test coverage, and adds GitHub Actions-based CI/security automation.

Changes:

  • Introduces PgSqlCaller::Model and PgSqlCaller::BulkUpdate, and refactors PgSqlCaller::Base into a thin singleton facade over Model.
  • Raises minimum Ruby to 3.2 and constrains ActiveRecord/ActiveSupport to >= 7.1; updates RuboCop and adds security/tooling automation.
  • Adds/updates specs, README, CHANGELOG, and GitHub Actions workflows (CI, CodeQL, bundle-audit, Semgrep, Dependabot).

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sql_caller.gemspec Updates gem description, runtime file list, and minimum Ruby/AR dependencies.
spec/spec_helper.rb Adjusts RSpec hooks and excludes benchmark-tagged specs by default.
spec/pg_sql_caller/model_spec.rb Adds comprehensive specs for the new PgSqlCaller::Model API.
spec/pg_sql_caller/bulk_update_spec.rb Adds specs (and an optional benchmark) for PgSqlCaller::BulkUpdate.
spec/pg_sql_caller/base_spec.rb Adds/refactors specs for PgSqlCaller::Base behavior.
spec/pg_sql_caller_spec.rb Minor spec cleanup (be_nil matcher).
spec/pg_sql_caller_base_spec.rb Removes old base spec file in favor of reorganized specs.
spec/fixtures/active_record.rb Test ActiveRecord setup tweaks (logger, abstract base model).
spec/config/database.travis.yml Removes Travis-specific DB config.
spec/config/database.github.yml Adds GitHub Actions DB config for CI.
README.md Major documentation expansion: API reference, security, bulk update docs, development notes.
lib/pg_sql_caller/version.rb Bumps version to 1.0.0.
lib/pg_sql_caller/model.rb Adds the new instantiable SQL wrapper and helper APIs.
lib/pg_sql_caller/bulk_update.rb Adds set-based bulk update implementation using UPDATE ... FROM unnest(...).
lib/pg_sql_caller/base.rb Refactors Base into a singleton facade subclassing Model.
lib/pg_sql_caller.rb Updates requires to load model and bulk_update.
gemfiles/rails_8_1.gemfile Adds CI gemfile for Rails 8.1 series.
gemfiles/rails_8_0.gemfile Adds CI gemfile for Rails 8.0 series.
gemfiles/rails_7_2.gemfile Adds CI gemfile for Rails 7.2 series.
gemfiles/rails_7_1.gemfile Adds CI gemfile for Rails 7.1 series.
Gemfile Updates dev tooling (RuboCop/plugins, bundle-audit) and bumps RSpec/Rake versions.
CHANGELOG.md Adds changelog with 1.0-era breaking changes and new features.
.travis.yml Removes Travis CI configuration.
.semgrep/sql-injection.yml Adds custom Semgrep rule for interpolated SQL use.
.rubocop.yml Updates RuboCop configuration for Ruby 3.2 and new plugins.
.gitignore Ignores gemfile lockfiles under gemfiles/.
.github/workflows/codeql.yml Adds CodeQL scanning workflow for Ruby.
.github/workflows/ci.yml Adds GitHub Actions CI matrix (Ruby/Rails) plus RuboCop, bundle-audit, Semgrep.
.github/workflows/bundle-audit.yml Adds scheduled bundle-audit workflow.
.github/dependabot.yml Adds Dependabot configuration for bundler updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/pg_sql_caller/model.rb
Comment thread lib/pg_sql_caller/model.rb
Comment thread lib/pg_sql_caller/bulk_update.rb
Comment thread lib/pg_sql_caller/bulk_update.rb
Comment thread lib/pg_sql_caller/bulk_update.rb
Comment thread lib/pg_sql_caller/base.rb
Comment thread .github/workflows/ci.yml Outdated
Comment thread lib/pg_sql_caller/model.rb Dismissed
@senid231 senid231 force-pushed the version-1-0 branch 2 times, most recently from 0292112 to bcdd2f6 Compare June 8, 2026 12:19
@senid231 senid231 requested a review from Copilot June 8, 2026 12:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 29 out of 30 changed files in this pull request and generated 4 comments.

Comment thread lib/pg_sql_caller/base.rb
Comment thread lib/pg_sql_caller/model.rb
Comment thread CHANGELOG.md Outdated
Comment thread spec/pg_sql_caller/bulk_update_spec.rb
@senid231 senid231 merged commit ba62992 into master Jun 8, 2026
10 checks passed
@senid231 senid231 deleted the version-1-0 branch June 8, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants