Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when the adapter changes its content #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash when the adapter changes its content #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions rtlviewpager/src/main/java/com/booking/rtlviewpager/PagerAdapterWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.booking.rtlviewpager;

import android.database.DataSetObservable;
import android.database.DataSetObserver;
import android.os.Parcelable;
import android.support.annotation.NonNull;
Expand All @@ -29,9 +30,23 @@ class PagerAdapterWrapper extends PagerAdapter {

@NonNull
private final PagerAdapter adapter;
private final DataSetObservable dataSetObservable = new DataSetObservable();


protected PagerAdapterWrapper(@NonNull PagerAdapter adapter) {
this.adapter = adapter;
this.adapter.registerDataSetObserver(new DataSetObserver() {
@Override
public void onChanged() {
PagerAdapterWrapper.super.notifyDataSetChanged();
dataSetObservable.notifyChanged();
}

@Override
public void onInvalidated() {
dataSetObservable.notifyInvalidated();
}
});
}

@NonNull
Expand Down Expand Up @@ -86,12 +101,12 @@ public void notifyDataSetChanged() {

@Override
public void registerDataSetObserver(DataSetObserver observer) {
adapter.registerDataSetObserver(observer);
dataSetObservable.registerObserver(observer);
}

@Override
public void unregisterDataSetObserver(DataSetObserver observer) {
adapter.unregisterDataSetObserver(observer);
dataSetObservable.unregisterObserver(observer);
}

@Override
Expand Down