Skip to content

build: upgrade javacc-maven-plugin from 2.4 to 3.2.0 - #624

Open
NiccoMlt wants to merge 4 commits into
masterfrom
561-upgrade-javacc-maven-plugin-to-311
Open

build: upgrade javacc-maven-plugin from 2.4 to 3.2.0#624
NiccoMlt wants to merge 4 commits into
masterfrom
561-upgrade-javacc-maven-plugin-to-311

Conversation

@NiccoMlt

@NiccoMlt NiccoMlt commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Upgrades the generator behind the request-matcher DSL to recent JavaCC version.

Closes #561

Note

JavaCC 8 exists, shipped under new coordinates (org.javacc:core, org.javacc.generator:java 8.1.0) and driven by its own rewritten plugin (org.javacc.plugin:javacc-maven-plugin 3.8.0).

Though, both were published only a few months ago, and as far as I can tell it ships with a different configuration model.

This PR stays on the 7.x line and leaves the v8 migration to a dedicated issue.

What changed

javacc-maven-plugin was stuck on a version from Maven 2-era.

One commit per plugin generation, so each transition is bisectable:

Plugin JavaCC Notable change
2.4 → 2.6 4.0 → 5.0 generator only
2.6 → 3.0.1 5.0 → 7.0.12 Maven 3 rewrite: annotation mojos, javacc. property prefix, grammar options {} no longer overridden
3.0.1 → 3.2.0 7.0.12 → 7.0.13 thread-safe mojos, Doxia 2.0, grammars read with configured encoding
7.0.13 pinned generator version was invisible in the POM; now a plugin dependency

Grammar was unchanged, as 7.0.13 accepts it as-is.

Generated code stays under target/. Deltas on generated code are cosmetic.

NiccoMlt added 4 commits July 29, 2026 23:11
Moves parser generation from JavaCC 4.0 to 5.0.
Maven 3 rewrite of the plugin: annotation mojos, javacc. prefix on user
properties, and grammar options no longer overridden by plugin defaults.
Generator goes from JavaCC 5.0 to 7.0.12.
Thread-safe mojos, Doxia 2.0, and grammars read with the configured
encoding. Needs Maven 3.6.3+, already guaranteed. Generator goes from
JavaCC 7.0.12 to 7.0.13.
The plugin bundles its own JavaCC, so the generator version was
invisible in the POM and moved at every plugin bump.
@NiccoMlt NiccoMlt linked an issue Jul 29, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 325757b5-cb28-45e9-896d-8bf3ff03322f

📥 Commits

Reviewing files that changed from the base of the PR and between 0d4f20f and edfa51f.

📒 Files selected for processing (1)
  • pom.xml

📝 Walkthrough

Walkthrough

The parent Maven configuration upgrades javacc-maven-plugin from 2.4 to 3.2.0, updates the JavaCC library version to 7.0.13, and explicitly adds the JavaCC artifact as a plugin dependency.

Assessment against linked issues

Objective Addressed Explanation
Upgrade the JavaCC Maven plugin to the requested version [#561] The POM uses 3.2.0 instead of the requested 3.1.1.
Audit grammars and verify build/tests after the upgrade [#561] No grammar changes or build/test verification are shown in the provided changes.

Suggested reviewers: diennea-bot

Poem

A rabbit hopped through Maven’s gate,
And found JavaCC made up-to-date.
New versions sprang from every line,
Dependencies aligned just fine.
“Build onward!” cheered the bunny bright.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 561-upgrade-javacc-maven-plugin-to-311

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NiccoMlt NiccoMlt self-assigned this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade JavaCC Maven plugin to 3.1.1

1 participant