build: upgrade javacc-maven-plugin from 2.4 to 3.2.0 - #624
Conversation
Moves parser generation from JavaCC 4.0 to 5.0.
Maven 3 rewrite of the plugin: annotation mojos, javacc. prefix on user properties, and grammar options no longer overridden by plugin defaults. Generator goes from JavaCC 5.0 to 7.0.12.
Thread-safe mojos, Doxia 2.0, and grammars read with the configured encoding. Needs Maven 3.6.3+, already guaranteed. Generator goes from JavaCC 7.0.12 to 7.0.13.
The plugin bundles its own JavaCC, so the generator version was invisible in the POM and moved at every plugin bump.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe parent Maven configuration upgrades Assessment against linked issues
Suggested reviewers: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Upgrades the generator behind the request-matcher DSL to recent JavaCC version.
Closes #561
Note
JavaCC 8 exists, shipped under new coordinates (
org.javacc:core,org.javacc.generator:java8.1.0) and driven by its own rewritten plugin (org.javacc.plugin:javacc-maven-plugin3.8.0).Though, both were published only a few months ago, and as far as I can tell it ships with a different configuration model.
This PR stays on the 7.x line and leaves the v8 migration to a dedicated issue.
What changed
javacc-maven-pluginwas stuck on a version from Maven 2-era.One commit per plugin generation, so each transition is bisectable:
javacc.property prefix, grammaroptions {}no longer overriddenGrammar was unchanged, as 7.0.13 accepts it as-is.
Generated code stays under
target/. Deltas on generated code are cosmetic.