Optimize owned row #3999
Closed
Optimize owned row #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
approved these changes
Apr 24, 2024
diesel_bench/Cargo.toml
Outdated
| @@ -75,5 +75,5 @@ codegen-units = 1 | |||
|
|
|||
| [patch.crates-io] | |||
| quaint = { git = "https://github.com/prisma/prisma-engines", branch = "main" } | |||
| diesel-async = { git = "https://github.com/weiznich/diesel_async", branch = "main" } | |||
| diesel-async = { git = "https://github.com/wattsense/diesel_async", branch = "sync_wrapper_use_cache" } | |||
There was a problem hiding this comment.
Can we change this back to the original repo + the master branch? I will take care to merge both PR's at the same time to not break the benchmarking.
There was a problem hiding this comment.
Sure, I just removed all Cargo.toml changes.
This speeds up the benchmarks that loads 10.000 rows by 20-30%
momobel
force-pushed
the
optimize_owned_row
branch
from
b47c3fc to
b0fbe29
Compare
|
I just wanted to leave a note here that I have not forgot about this PR. I'm currently working on fixing the CI system issues. I will merge this PR after #4008 landed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes owned row caching and is based on changes @weiznich did to cache column names and add required benchmarks.
See weiznich/diesel_async#146 (comment)