ansi-c: more use of conditional_keyword#8625
Merged
Conversation
7e2b9cb to
eb41931
Compare
This replaces further instances of conditional keywords in the ANSI-C scanner by conditional_keyword(...).
eb41931 to
d948592
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8625 +/- ##
===========================================
+ Coverage 80.36% 80.38% +0.02%
===========================================
Files 1686 1686
Lines 206799 206764 -35
Branches 84 75 -9
===========================================
+ Hits 166200 166215 +15
+ Misses 40599 40549 -50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
approved these changes
Apr 10, 2025
| else | ||
| { loc(); return TOK_BOOL; } | ||
| } | ||
| "_Bool" { return conditional_keyword(!PARSER.cpp98, TOK_BOOL); } |
Collaborator
There was a problem hiding this comment.
As discussed offline: we really should rename PARSER.cpp98 to something like PARSER.cpp98_or_later as otherwise this is very confusing.
Collaborator
Author
There was a problem hiding this comment.
Will do as separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces further instances of conditional keywords in the ANSI-C scanner by
conditional_keyword(...).