introduce sva_boolean_exprt
#1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
sva_boolean_exprt
branch
4 times, most recently
from
e7e9a69 to
679576c
Compare
kroening
force-pushed
the
sva_boolean_exprt
branch
3 times, most recently
from
eba0908 to
28c0ba6
Compare
tautschnig
approved these changes
May 11, 2025
regression/verilog/SVA/sva_and1.desc
Outdated
| @@ -1,7 +1,7 @@ | |||
| CORE | |||
| sva_and1.sv | |||
|
|
|||
| ^\[main\.p0\] always \(1 and 1\): PROVED$ | |||
| ^\[main\.p0\] always \(1 and 1\): PROVED up to bound 5$ | |||
There was a problem hiding this comment.
Why did we previously claim this was proved unboundedly?
| @@ -23,12 +23,26 @@ Author: Daniel Kroening, [email protected] | |||
| exprt normalize_pre_sva_non_overlapped_implication( | |||
| sva_non_overlapped_implication_exprt expr) | |||
| { | |||
| // Same as a->always[1:1] b if lhs is not a sequence. | |||
| if(!is_SVA_sequence_operator(expr.lhs())) | |||
| // a|=>b is the same as a->always[1:1] b if lhs is not a proper sequence. | |||
There was a problem hiding this comment.
What is the difference between a sequence and a "proper" sequence?
src/trans-word-level/sequence.cpp
Outdated
Comment on lines
466
to
470
| DATA_CHECK_WITH_DIAGNOSTICS( | ||
| validation_modet::INVARIANT, | ||
| false, | ||
| "unexpected sequence expression", | ||
| expr.pretty()); |
There was a problem hiding this comment.
Suggested change
| DATA_CHECK_WITH_DIAGNOSTICS( | |
| validation_modet::INVARIANT, | |
| false, | |
| "unexpected sequence expression", | |
| expr.pretty()); | |
| DATA_INVARIANT_WITH_DIAGNOSTICS( | |
| false, | |
| "unexpected sequence expression", | |
| expr.pretty()); |
kroening
force-pushed
the
sva_boolean_exprt
branch
2 times, most recently
from
b374490 to
36488ba
Compare
IEEE 1800-2017 16.6 Boolean expressions introduces rules on how to convert Boolean expressions into SVA sequences or properties. This introduces an expression for this conversion.
kroening
force-pushed
the
sva_boolean_exprt
branch
from
36488ba to
9964659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IEEE 1800-2017 16.6 Boolean expressions introduces rules on how to convert Boolean expressions into SVA sequences or properties. This introduces an expression for this conversion.