docs: fix stale references after dockview/migration/quit refactors#237
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
ed39cff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b02c630f.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-docs-staleness-post-refa.mouseterm.pages.dev |
Member
|
I think this might be stale. Try to merge |
- AGENTS.md: drop the stale "one-way legacy-blob migration reader" clause from the tiling-engine.md index entry — that reader was deleted. - docs/specs/standalone.md: the structural save trigger is a Lath store commit (use-session-persistence.ts:137), not a dockview event. - standalone/src/tauri-adapter.ts: the quit orchestrator (quit.ts) shipped and now calls requestSessionFlush — drop "(future)". - docs/specs/dor-cli.md: `dor list --json` also emits top-level workspace_ref / window_ref (list.ts:235-236); add them to the prose. Docs/comment-only, no behavior change. Rebuilt on current main after #239's dor CLI rework; pnpm lint:specs passes (23 specs, 24 files). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
c956a7a to
ed39cff
Compare
Collaborator
Author
|
Good call to check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly survey found four spots where docs and a code comment describe behavior the recent refactors (#230, #231, #232, #234) already changed. All fixes are documentation/comment-only — no behavior change — so no regression test applies.
AGENTS.md— thetiling-engine.mdindex entry still advertised "Lath-only persistence with a one-way legacy-blob migration reader". Delete old-persistence migration tech-debt #232 deleted that migration reader (andtiling-engine.md's own## Persistencesection was already updated). Dropped the stale clause.docs/specs/standalone.md— the Dirty-gated writes section described the structural save trigger as "Structural dockview events" / "with no dockview event". Dockview is gone; the trigger is a Lath store commit (use-session-persistence.ts:133→lath.store.subscribe(scheduleSessionSave)). Reworded to "Lath store commits" / "no Lath commit". docs: retire dockview references in DESIGN.md after Lath (#228) #231 retired dockview references but missed this occurrence.standalone/src/tauri-adapter.ts—requestSessionFlush's comment said it's "Called by the (future) quit orchestrator". The orchestrator (standalone/src/quit.ts) shipped in Standalone quit flow: graceful teardown, durable final save, session-persistence hardening #230 and now calls it. Dropped "(future)".docs/specs/dor-cli.md— thedor list --jsondescription listedcaller_surface_ref,focused_surface_ref, and thehostblock, but omitted the top-levelworkspace_ref/window_reffields thatrenderListJsonalso emits (dor/src/commands/list.ts:164). The command's own help snapshot already documents them; brought the spec prose in line.pnpm lint:specspasses (23 specs, 24 files).