Skip to content

docs: fix stale references after dockview/migration/quit refactors#237

Merged
nedtwigg merged 1 commit into
mainfrom
fix/docs-staleness-post-refactor
Jul 10, 2026
Merged

docs: fix stale references after dockview/migration/quit refactors#237
nedtwigg merged 1 commit into
mainfrom
fix/docs-staleness-post-refactor

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

Nightly survey found four spots where docs and a code comment describe behavior the recent refactors (#230, #231, #232, #234) already changed. All fixes are documentation/comment-only — no behavior change — so no regression test applies.

  • AGENTS.md — the tiling-engine.md index entry still advertised "Lath-only persistence with a one-way legacy-blob migration reader". Delete old-persistence migration tech-debt #232 deleted that migration reader (and tiling-engine.md's own ## Persistence section was already updated). Dropped the stale clause.
  • docs/specs/standalone.md — the Dirty-gated writes section described the structural save trigger as "Structural dockview events" / "with no dockview event". Dockview is gone; the trigger is a Lath store commit (use-session-persistence.ts:133lath.store.subscribe(scheduleSessionSave)). Reworded to "Lath store commits" / "no Lath commit". docs: retire dockview references in DESIGN.md after Lath (#228) #231 retired dockview references but missed this occurrence.
  • standalone/src/tauri-adapter.tsrequestSessionFlush's comment said it's "Called by the (future) quit orchestrator". The orchestrator (standalone/src/quit.ts) shipped in Standalone quit flow: graceful teardown, durable final save, session-persistence hardening #230 and now calls it. Dropped "(future)".
  • docs/specs/dor-cli.md — the dor list --json description listed caller_surface_ref, focused_surface_ref, and the host block, but omitted the top-level workspace_ref / window_ref fields that renderListJson also emits (dor/src/commands/list.ts:164). The command's own help snapshot already documents them; brought the spec prose in line.

pnpm lint:specs passes (23 specs, 24 files).

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed39cff
Status: ✅  Deploy successful!
Preview URL: https://b02c630f.mouseterm.pages.dev
Branch Preview URL: https://fix-docs-staleness-post-refa.mouseterm.pages.dev

View logs

@nedtwigg

nedtwigg commented Jul 9, 2026

Copy link
Copy Markdown
Member

I think this might be stale. Try to merge origin/main and see if this PR still makes sense or not.

- AGENTS.md: drop the stale "one-way legacy-blob migration reader" clause
  from the tiling-engine.md index entry — that reader was deleted.
- docs/specs/standalone.md: the structural save trigger is a Lath store
  commit (use-session-persistence.ts:137), not a dockview event.
- standalone/src/tauri-adapter.ts: the quit orchestrator (quit.ts) shipped
  and now calls requestSessionFlush — drop "(future)".
- docs/specs/dor-cli.md: `dor list --json` also emits top-level
  workspace_ref / window_ref (list.ts:235-236); add them to the prose.

Docs/comment-only, no behavior change. Rebuilt on current main after #239's
dor CLI rework; pnpm lint:specs passes (23 specs, 24 files).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dormouse-bot dormouse-bot force-pushed the fix/docs-staleness-post-refactor branch from c956a7a to ed39cff Compare July 10, 2026 00:01
@dormouse-bot

Copy link
Copy Markdown
Collaborator Author

Good call to check. origin/main had its history collapsed to a single squashed commit (#239, the dor CLI rework) with no common ancestor to this branch, so a plain merge would have joined unrelated histories. I rebuilt the branch on top of current main instead and re-verified each fix against the live code:

  • AGENTS.md — still stale; the legacy-blob migration reader is gone (no references in tiling-engine.md or lib/src/lib/lath/). Applied unchanged.
  • standalone.md — still stale; the structural trigger is lath.store.subscribe(scheduleSessionSave) (use-session-persistence.ts:137), not a dockview event. Applied unchanged.
  • tauri-adapter.ts — still stale; the quit orchestrator shipped (standalone/src/quit.ts calls requestSessionFlush). Dropped "(future)".
  • dor-cli.mdRework the dor CLI into a cohesive agent surface #239 reworked this section, so the original diff no longer applied cleanly, but the fix is still valid: renderListJson emits top-level workspace_ref / window_ref (list.ts:235-236, documented at list.ts:54) that the prose omits. Re-applied against the new text, in the code's own field ordering.

pnpm lint:specs passes (23 specs, 24 files). Force-pushed the rebuilt branch — still makes sense, just freshened onto current main.

@nedtwigg nedtwigg merged commit 6fbecf8 into main Jul 10, 2026
4 checks passed
@nedtwigg nedtwigg deleted the fix/docs-staleness-post-refactor branch July 10, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants