Implement "synology" compat option for Synology NAS #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the Synology DSM "btrfs send" command outputs ACL attributes that are not compatible with a normal Btrfs implementation. The option compat "synology" allows passing the --without-syno-features option, which makes "btrfs send" compatible with standard Btrfs implementations.
|
@digint This is an optional feature which is not enabled by default. Do you need any improvements for this MR before it can be merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the Synology "btrfs send" command will send a lot of ACLs and maybe other information, a standard btrfs can't deal with.
I've discovered that it's possible to turn this behavior off with
--without-syno-featuresand let it behave like a normalbtrfs send, allowing btrbk to send Snapshots to a non Synology btrfs.Maybe #383 already tried to address this issue, but for me the btrbk run still failed. With this change here, all receive errors are gone.
I've also added an example in the config how to archive all Synology subfolders at once.