This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Use CFBundleLocalizations for iOS localization#27
Open
ThijmenDeValk wants to merge 2 commits intomainfrom
Open
Use CFBundleLocalizations for iOS localization#27ThijmenDeValk wants to merge 2 commits intomainfrom
ThijmenDeValk wants to merge 2 commits intomainfrom
Conversation
bitcrumb
reviewed
Oct 25, 2024
| config.modResults["LOCALES_SUPPORTED"] = locales.join(","); | ||
| config.modResults["CFBundleAllowMixedLocalizations"] = true; | ||
| config.modResults["CFBundleLocalizations"] = locales; | ||
| config.modResults["CFBundleDevelopmentRegion"] = "en"; |
There was a problem hiding this comment.
Just a small heads up that you might want to make this configurable (and maybe the CFBundleAllowMixedLocalizations as well).
Member
Author
There was a problem hiding this comment.
Good point. I do think these are the sane defaults for folks that don't explicitly set them, though.
There was a problem hiding this comment.
Agree, no harm in having a sane default. You could surely have the config optional and fallback to these as default :)
I am testing out the beta as we speak btw.
fix: don't link to specific Expo version fix: run expo-module prepare in prepare script chore: update deps
|
Any chance we can get this released? 😁 |
Member
Author
|
@bitcrumb Sorry, been a busy couple of weeks 😅 I'll get it out the door later this week. Had some tweaks I wanted to make for Expo 52 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the iOS implementation by using CFBundleLocalizations in the Info.plist instead of the convoluted method of creating empty placeholder files.
Fixes #20 and closes #23