Move mdocContext unit tests into mocha test suite.#223
Open
djscruggs wants to merge 1 commit into
Open
Conversation
Converts the standalone test/unit/mdocContext.test.js (added in PR #219) into a standard mocha suite at test/mocha/91-mdoc-context.js so it runs under the common testing system, npm test, and CI. Removes the ad-hoc test:unit script and the test/unit directory. Addresses #222. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 18 18
Lines 3678 3678
=======================================
Hits 3382 3382
Misses 296 296 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the standalone
test/unit/mdocContext.test.js(added in #219) into a standard mocha suite attest/mocha/91-mdoc-context.jsso it runs under the common testing system,npm test, and CI.test()/assert()harness withdescribe/itand chaishouldassertions; test behaviors are unchanged (sign an mDL viamdocContext, verify against a trusted chain, reject an untrusted certificate).test:unitscript and thetest/unit/directory; no references remain.There was no strong reason for the standalone runner beyond skipping Bedrock stack startup during development —
--mocha-testcovers that need without a parallel test system.Closes #222.
🤖 Generated with Claude Code