Skip to content

feat: add wait_for_completion method to IndexingJobs resource with sy… #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add wait_for_completion method to IndexingJobs resource with sy… #49

wants to merge 14 commits into from

Conversation

areeb1501
Copy link

Fixes #41

bbatha
bbatha reviewed Oct 20, 2025
View reviewed changes
bbatha
bbatha reviewed Oct 20, 2025
View reviewed changes
bbatha
bbatha requested changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@bbatha bbatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dedicated error types and add tests

bbatha
bbatha reviewed Oct 20, 2025
View reviewed changes
src/gradient/resources/knowledge_bases/indexing_jobs.py Outdated
Comment on lines 268 to 269
poll_interval: int = 5,
timeout: int | None = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be float not int

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified this to float.

@areeb1501
Copy link
Author

@bbatha can you please review the changes and test cases and share your comments on the same?

bbatha
bbatha reviewed Oct 22, 2025
View reviewed changes
examples/knowledge_base_indexing_wait.py Outdated
Comment on lines 178 to 181
except TimeoutError as e:
print(f"\n⏱️ Timeout: {e}")
except RuntimeError as e:
print(f"\n❌ Error: {e}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be the new types you introduced

bbatha
bbatha requested changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@bbatha bbatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close could you just make sure the example is updated with the new exception types.

This was referenced Oct 22, 2025
Closed
Closed
Closed
@areeb1501
Copy link
Author

Very close could you just make sure the example is updated with the new exception types.

I've replaced all instances of generic execution error types with the newly created ones.

@areeb1501
Copy link
Author

@bbatha can you please take a look at the new changes? I've updated the error types in the example.

@bbatha
Copy link
Collaborator

bbatha commented Oct 22, 2025

There's a lint issue still @areeb1501 can you make sure to run /scripts/format

@areeb1501
Copy link
Author

@bbatha I've run that script. Can you please check and approve the remaining workflows?

@bbatha
Copy link
Collaborator

bbatha commented Oct 23, 2025

The linter appears to be picking up one last type error could you make sure that is resolved?

@areeb1501
Copy link
Author

@bbatha I have made the changes. Can you please take a look at this and approve the remaining workflows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbatha bbatha bbatha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a helper function to poll for knowledge base indexing completion

2 participants

@areeb1501 @bbatha