Skip to content

fix for issue 124 (Signature size for RSA 3072 and 4096 bits is too small)#125

Open
mitresthen wants to merge 2 commits intodigitorus:mainfrom
mitresthen:signature_size
Open

fix for issue 124 (Signature size for RSA 3072 and 4096 bits is too small)#125
mitresthen wants to merge 2 commits intodigitorus:mainfrom
mitresthen:signature_size

Conversation

@mitresthen
Copy link

Add a hopefully more correct way of calculating signature size, based on how it's done in other pdf signing libraries. Set an upper limit on retries to avoid a loop. Reset state inbetween retries to avoid corrupt pdf's.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 70.73171% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.03%. Comparing base (b62ffc7) to head (c9c59a5).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
sign/keysize.go 72.72% 6 Missing and 6 partials ⚠️
sign/pdfsignature.go 46.66% 6 Missing and 2 partials ⚠️
sign/sign.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   60.42%   62.03%   +1.60%     
==========================================
  Files          25       26       +1     
  Lines        1908     1973      +65     
==========================================
+ Hits         1153     1224      +71     
+ Misses        590      579      -11     
- Partials      165      170       +5     
Flag Coverage Δ
unittests 62.03% <70.73%> (+1.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant