Pin androidx.appcompat to 1.7.0 explicitly (post-Firebase-BOM-33.16.0 follow-up)#3692
Draft
avazirna wants to merge 1 commit intodeps/firebase-bom-33.16.0from
Draft
Pin androidx.appcompat to 1.7.0 explicitly (post-Firebase-BOM-33.16.0 follow-up)#3692avazirna wants to merge 1 commit intodeps/firebase-bom-33.16.0from
avazirna wants to merge 1 commit intodeps/firebase-bom-33.16.0from
Conversation
Firebase BOM 33.16.0 transitively forces appcompat 1.2.0 -> 1.7.0 via firebase SDK dependency constraints. This commit makes that upgrade explicit at the user-facing pin so it's visible in the build file rather than hidden in the resolution graph. No behavioral change vs. the BOM bump alone — Gradle was already resolving appcompat to 1.7.0 transitively. Making it explicit lets git blame surface the appcompat upgrade as an intentional change and makes the build file's stated versions match what's actually shipped. Part of the post-BOM-bump AndroidX impact follow-up tracked in the Firebase BOM 33.16.0 PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Summary
Stacked on top of the Firebase BOM 33.16.0 PR (#3691). After that bump,
androidx.appcompatis already being resolved to 1.7.0 transitively via the BOM's Firebase SDK constraints — but the build file still declares1.2.0. This PR bumps the explicit pin to match what's actually shipping, so:git blameonapp/build.gradlesurfaces the appcompat upgrade as an intentional change.No behavioral change vs. the BOM bump alone — Gradle was already resolving appcompat to 1.7.0. This PR only changes the declaration.
Diff
One line.
Safety Assurance
Safety story
Automated test coverage
N/A. The build/test outcome is identical to the BOM PR (since the resolved bytes are the same).
QA Plan
./gradlew :app:dependenciesand confirm appcompat:1.7.0 is reported with no(*)substitution arrow on the explicit declaration line.Labels and Review
Out of scope (deliberately)
These would be sensible follow-ups but are not in this PR:
lifecycle_versionfrom2.5.1→2.9.0to match the BOM-resolved value.legacy_support_version(currently 1.0.0) to a more current AndroidX legacy compat.core,fragment,activity-ktx,annotation, or any other AndroidX library getting transitively bumped.