create new release on deploy to production#1133
Conversation
calellowitz
requested review from
Charl1996,
ajeety4,
hemant10yadav,
mkangia,
pxwxnvermx,
sravfeyn and
zandre-eng
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe deploy GitHub Actions workflow now grants the GITHUB_TOKEN write access to repository contents and, on successful production runs, sets RELEASE_TAG to a UTC timestamp (YYYY-MM-DD_HH-MM-SS) and creates a GitHub Release using that tag/name targeting github.sha with generated release notes. These steps run after Sentry release creation; the Slack notify step still runs with if: always(). Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| tag_name: ${{ env.RELEASE_DATE }} | ||
| name: ${{ env.RELEASE_DATE }} | ||
| target_commitish: ${{ github.sha }} | ||
| generate_release_notes: true |
There was a problem hiding this comment.
What does this do? List all PRs and descriptions?
There was a problem hiding this comment.
yeah, its the same thing that currently happens when you press the button manually. Its a builtin github option
| if: ${{ success() && inputs.environment == 'production' }} | ||
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| tag_name: ${{ env.RELEASE_DATE }} |
There was a problem hiding this comment.
what happens if there are two deploys on the same day?
There was a problem hiding this comment.
That's a great question, this step would probably fail. I think that's a pretty rare occurrence, but not impossible. HQ uses the time as well. That would be easy to add
There was a problem hiding this comment.
so you want to add that or use just the date?
There was a problem hiding this comment.
sorry took a while, but did update the tag. feel free to review again
6 participants
Technical Summary
This updates the deploy workflow to create a release automatically when deploying to production
Safety Assurance
Safety story
deploy workflow only
QA Plan
Tested on staging
Labels & Review