Apply djlint to Reformat all Django Templates#1166
Open
zandre-eng wants to merge 2 commits intomainfrom
Open
Conversation
zandre-eng
requested review from
ajeety4,
calellowitz,
hemant10yadav,
mkangia,
pxwxnvermx and
sravfeyn
Contributor
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (139)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zandre-eng
force-pushed
the
ze/frontend-linting-reformat
branch
from
6b3ec61 to
acef025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
No user-facing changes. This PR applies automated indentation reformatting to all 139 Django HTML templates and fixes a small number of pre-existing HTML issues, as a prerequisite for the frontend linting PR (CCCT-2388).
Technical Summary
CCCT-2388
Two commits:
chore: apply djlint reformat to all Django templates— pure whitespace/indentation normalisation generated byuvx djlint commcare_connect/templates/ --reformat --profile=django --indent=2. Safe to review with whitespace-hidden diffs (?w=1on GitHub).fix: lowercase form method and remove empty class attributes (H029, H026)— 7 targeted content fixes across 7 files:method="POST"lowercased tomethod="post"in 4 templates, emptyclass=""attributes removed in 3 templates. Both are inert changes (HTML form method is case-insensitive; empty class attributes have no effect).This PR exists as a base for the hooks PR so that CI does not fail when
djlint-reformat-djangoruns--all-fileson an unformatted codebase.Safety Assurance
Safety story
No Python, JavaScript, model, or view logic touched. Django renders templates identically regardless of indentation. Form method case is normalised by browsers and Django's
request.methodis always uppercased server-side. Emptyclass=""attributes match no CSS selectors or JavaScript. The change is fully reversible by reverting both commits.Automated test coverage
No tests added or modified. Existing test suite covers template rendering behaviour and is unaffected by these changes.
QA Plan
QA will not be performed for this change. Below is the testing plan for reference:
?w=1on GitHub) to confirm no content changesLabels & Review