Use our own memory area for editing libpq static error messages #903
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitri
requested changes
Feb 19, 2025
dimitri
changed the title
dimitri
approved these changes
Feb 19, 2025
hanefi
reviewed
Feb 21, 2025
dimitri
approved these changes
Feb 24, 2025
|
Seems editing with the GitHub web UI makes it hard to pass our CI indentation test. At the minute I need to refresh my dev environment (Docker and macOS issues, re-install Citus indentation tooling). Will have another try later this week. |
I couldn't get your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see segmentation fault described in neondatabase/neon#10706