Fix "reset sequences" crash on tables with case sensitive column names#1509
Open
codereverser wants to merge 1 commit intodimitri:masterfrom
Open
Fix "reset sequences" crash on tables with case sensitive column names#1509codereverser wants to merge 1 commit intodimitri:masterfrom
codereverser wants to merge 1 commit intodimitri:masterfrom
Conversation
…mn names (quote-identifiers)
|
Is this something that can be merged in soon? facing this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On case sensitive migrations (i.e. with "quote identifiers"), reset sequences fail with the following error.
This is due to invalid parameters being passed to
pg_get_serial_sequencefunction introduced in e32066dfor example, on a mysql table with following definition
throws the same error, but the following works
ref: #425