Quick & dirty fix for KiCad Python Paths on Windows #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LK
reviewed
Jul 27, 2025
Comment on lines
+63
to
+67
| std::env::var("KICAD_PYTHON_INTERPRETER") | ||
| .unwrap_or_else(|_| "python.exe".to_string()), |
There was a problem hiding this comment.
Would this default to using the system python.exe if KICAD_PYTHON_INTERPRETER isn't defined?
There was a problem hiding this comment.
The actual interpreter will/should run from the PATH, but the site-packages functions will not recognize the directory structure.
Personally, I'd create a fallback fn to scan the path (equivalent ofwhich) would facilitate what you are suggesting in a more complete way.
There was a problem hiding this comment.
I just updated the PR to resolve a compilation issue the windows fix caused the other build targets
…interpreter` parent path - Add `user` install location for `KiCad` interpreter check > NOTE: This is quick & DIRTY, better error handling and error messages should be added in addition. Also, `Vec<Path>` find first should be added checking all provided candidates, etc
jglanz
force-pushed
the
fix/kicad-paths-for-windows
branch
from
5866d38 to
bb81b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick & dirty fix for KiCad Python Paths on Windows
venvsite-packages path resolution more robust by checkinginterpreterparent pathuserinstall location forKiCadinterpreter check