Skip to content

Update Visual Editor Documentation #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hola-soy-milk
Copy link
Contributor

No description provided.

@hola-soy-milk hola-soy-milk requested a review from a team as a code owner April 24, 2025 10:32
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 6:44pm

Copy link
Contributor

@formfcw formfcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the images and reviewed the changes so far.

Thank you @hola-soy-milk ! A few minor things …

::

This can then be included in your website like as follows:

```js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add more info about unpkg.com? We might add a link to https://unpkg.com if users need more information (e.g. about how to use specific versions).

Copy link
Member

@AlexGaillard AlexGaillard Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the info be?

@@ -28,6 +28,11 @@ The library ships with a number of built in CSS Selectors already applied to its
.directus-visual-editing-rect-hover {
/* class that applies when the original element is hovered */
}

.directus-visual-editing-rect-parent-hover {
/* class that applies to the parent element when the original element is hovered */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* class that applies to the parent element when the original element is hovered */
/* class that applies to the parent element when a children element is hovered */

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "a child" rather than "a children"

@@ -54,6 +59,7 @@ The library also ships with a number of predefined CSS variables. These can be o
--directus-visual-editing--edit-btn--bg-color: #6644ff;
--directus-visual-editing--edit-btn--icon-bg-image: url('data:image/svg+xml,<svg>…</svg>');
--directus-visual-editing--edit-btn--icon-bg-size: 66.6%;
--directus-visual-editing--rect-hover--opacity: 0.333;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make more sense to insert this before --directus-visual-editing--rect-highlight--opacity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let Carmen make that change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants