-
Notifications
You must be signed in to change notification settings - Fork 30
Major Upgrade - Latest Nuxt Packages #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, @bryantgillespie! I'm making a very high-level review of things I've noticed so far and leaving some comments:
Links for "Read more" types not hoverable/discoverable as links
See for example in /guides/data-model/collections#live-preview
:
Sidebar for tutorials is repetitive
I want to be very clear that this is not an issue on your end! I think the sidebar is fantastic and would love to rethink how we can make this better.
Since you mention that we're grouping this by tags, it shouldn't be an issue, however.
(extreme nitpick/opening to discussion): Should the top bar menus be lists?
I'm very unsure on this one. I love how it looks for the guides, but for the resources/manage sections, it feels chunky:
other praise
- Love the new look overall!
- Feels snappier to develop
- Thank you for bringing back long-requested features!
I'm excited for this to move forward ✨ 💜
</script> | ||
|
||
<template> | ||
<UPage> | ||
<UPageHeader | ||
:title="page!.title" | ||
:description="page!.description" | ||
:links="page!.links" | ||
:items="page!.links" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to be getting the following error:
ERROR [request error] [fatal] [GET] http://localhost:3000/docs/_nuxt/virtual:nuxt:%2FUsers%2Framonh%2Fclient-work%2Fdirectus%2Fdocs%2F.nuxt%2Fnuxt-fonts-global.css
ℹ Error: Page not found
⁃ at createError (node_modules/.pnpm/[email protected]/node_modules/h3/dist/index.mjs:71:15)
⁃ at createError (node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_@[email protected]_xz56x55az74yeoaat3dhskkduu/node_modules/nuxt/dist/app/composables/error.js:39:58)
⁃ at setup (app/pages/[...slug].vue:32:51)
27 ┃ <template>
28 ┃ <UPage>
29 ┃ <UPageHeader
30 ┃ :title="page!.title"
31 ┃ :description="page!.description"
❯ 32 ┃ :items="page!.links"
33 ┃ :headline="headline"
34 ┃ :ui="{ headline: 'headline', title: 'title' }"
35 ┃ >
36 ┃ <template #links>
37 ┃ <CopyDocButton :page="page" />
[CAUSE]
{
statusCode: 404,
statusMessage: 'Page not found',
fatal: true,
}
Lots of changes in this one. Biggest one is upgrading Nuxt packages significantly improves dev performance.
Notable Changes
Add support for copy raw page to markdown (for LLMs)
Newsletter Callout at bottom of page
Tweaks to API Reference
Still Left To Do
/tutorials
routes (shows all tutorials, should only show tutorial sections and tags (technologies)