Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add soundboard #10590

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Adds soundboard for mainlib

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:56pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 6:56pm

@Jiralite

This comment has been minimized.

@sdanialraza sdanialraza force-pushed the feat/add-soundboard branch 2 times, most recently from f3031c1 to 55725d0 Compare February 8, 2025 14:26
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.11%. Comparing base (4d19426) to head (02d2783).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10590      +/-   ##
==========================================
- Coverage   39.66%   39.11%   -0.55%     
==========================================
  Files         249      244       -5     
  Lines       15206    14796     -410     
  Branches     1456     1414      -42     
==========================================
- Hits         6031     5788     -243     
+ Misses       9163     8996     -167     
  Partials       12       12              
Flag Coverage Δ
proxy 64.63% <ø> (∅)
rest 87.37% <100.00%> (∅)
ws 34.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sdanialraza sdanialraza force-pushed the feat/add-soundboard branch 2 times, most recently from 830929a to 1e0fb55 Compare February 19, 2025 15:36
@sam51210

This comment was marked as off-topic.

Copy link
Contributor

@Qjuh Qjuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to add a get soundboardSound() to

this.soundId = data.sound_id ?? null;
which can be null if that sound_id is not found in the this.guild.soundboardSounds.cache.

@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Feb 27, 2025
@sdanialraza sdanialraza requested a review from Qjuh March 5, 2025 22:01
@sdanialraza sdanialraza requested a review from vladfrangu March 9, 2025 23:24
@sdanialraza sdanialraza requested a review from Jiralite March 18, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

6 participants