Skip to content

feat(Typing): cache member object #10786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Typing): cache member object #10786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aaa69d
feat(Typing): cache member object
Pavel-Boyazov Mar 1, 2025
0c2455c
fix: make member null if no data
Pavel-Boyazov Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/discord.js/src/structures/Typing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ class Typing extends Base {
*/
this.startedTimestamp = data.timestamp * 1_000;
}

/**
* The member that this guild typing instance represents
* @type {?GuildMember}
*/
this.member = data.member ? this.channel.guild.members._add(data.member, true) : null;
}

/**
Expand Down Expand Up @@ -60,15 +66,6 @@ class Typing extends Base {
get guild() {
return this.channel.guild ?? null;
}

/**
* The member who is typing
* @type {?GuildMember}
* @readonly
*/
get member() {
return this.guild?.members.resolve(this.user) ?? null;
}
}

exports.Typing = Typing;
2 changes: 1 addition & 1 deletion packages/discord.js/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3403,7 +3403,7 @@ export class Typing extends Base {
public startedTimestamp: number;
public get startedAt(): Date;
public get guild(): Guild | null;
public get member(): GuildMember | null;
public member: GuildMember | null;
public inGuild(): this is this & {
channel: TextChannel | AnnouncementChannel | ThreadChannel;
get guild(): Guild;
Expand Down