feat: components v2 in builders #10788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
didinele
requested changes
Mar 3, 2025
Qjuh
requested changes
Mar 3, 2025
vladfrangu
requested review from
iCrawl,
kyranet,
didinele,
Jiralite and
SpaceEEC
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10788 +/- ##
==========================================
+ Coverage 39.12% 39.99% +0.86%
==========================================
Files 244 253 +9
Lines 14798 15248 +450
Branches 1412 1469 +57
==========================================
+ Hits 5790 6098 +308
- Misses 8996 9138 +142
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Qjuh
previously requested changes
Mar 4, 2025
didinele
requested changes
Mar 5, 2025
packages/builders/src/components/selectMenu/StringSelectMenuOption.ts
Outdated
Show resolved
Hide resolved
vladfrangu
force-pushed
the
feat/components-v2
branch
from
73107a2 to
62124db
Compare
vladfrangu
force-pushed
the
feat/components-v2
branch
from
5ab5a10 to
20bd512
Compare
vladfrangu
force-pushed
the
feat/components-v2
branch
from
ecd6c68 to
a2aae6c
Compare
Qjuh
requested changes
Mar 14, 2025
Qjuh
approved these changes
Mar 18, 2025
Jiralite
reviewed
Mar 18, 2025
| * const thumbnail = new ThumbnailBuilder({ | ||
| * description: 'some text', | ||
| * media: { | ||
| * url: 'https://cdn.discordapp.com/embed/assets/4.png', |
There was a problem hiding this comment.
Suggested change
| * url: 'https://cdn.discordapp.com/embed/assets/4.png', | |
| * url: 'https://cdn.discordapp.com/embed/avatars/4.png', |
Jiralite
reviewed
Mar 18, 2025
| .refine((flags) => { | ||
| // If we have flags, ensure we don't have the ComponentsV2 flag | ||
| if (flags) { | ||
| return (flags & MessageFlags.IsComponentsV2) !== MessageFlags.IsComponentsV2; |
There was a problem hiding this comment.
This feels more idiomatic as it is not an inverse check:
Suggested change
| return (flags & MessageFlags.IsComponentsV2) !== MessageFlags.IsComponentsV2; | |
| return (flags & MessageFlags.IsComponentsV2) === 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
🤫
Status and versioning classification: