-
Notifications
You must be signed in to change notification settings - Fork 4
FEATURE: Add support for image attachments #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Sounds good to merge this separately from outbound attachments. Let me know when it is ready for review. (Given Draft status and conflict, I am guessing it is not yet ready.) Thanks @angusmcleod |
6f90bf9
to
9e0b66f
Compare
2a355a2
to
eb18a1e
Compare
@pmusaraj I've added attachment publication support to this PR. It's ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @angusmcleod, overall this looks good to me, just one question.
@@ -30,4 +30,12 @@ def include_content? | |||
def deleted? | |||
!object.stored.model || object.stored.model.trashed? | |||
end | |||
|
|||
def attachment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the spec only support one attachment per note/article?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It supports multiple. The spec (and implementers like mastodon) use the singular term attachment
, which actually an array of attachments. Yeah, I found it confusing too.
@pmusaraj This adds support for image attachments in the simplest way possible. This is the first step in adding media support.
Next steps after this are:
Notes:
Document
attachment types for images (instead ofImage
).