Update Prio3L1BoundSum for latest draft version#1396
Merged
divergentdave merged 4 commits intomainfrom Mar 6, 2026
Merged
Conversation
jcjones
approved these changes
Mar 5, 2026
Contributor
jcjones
left a comment
jcjones
left a comment
There was a problem hiding this comment.
I feel like I still have a mental block on understanding the invalid_measurements test, but as long as you understand it, hey.
I think that l1_norm overflow, if it's real, is important, but everything else is me being nitty. Good change.
| } | ||
|
|
||
| #[test] | ||
| fn invalid_measurements() { |
Contributor
There was a problem hiding this comment.
I don't feel like I understand what's going on here anymore. I'm going to come back to this.
jcjones
reviewed
Mar 5, 2026
jcjones
approved these changes
Mar 5, 2026
tgeoghegan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the L1BoundSum type to use the new range check, and removes the
experimentalCargo feature gate. The only remaining step is to check against updated test vectors, but that will have to wait for other VDAF draft-18 changes.Part of #1293.