feat: add IPv6 address support in URL parsing (fixes #400) #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for IPv6 addresses in WinRM endpoint URLs, enabling pywinrm to work in IPv6-only and dual-stack environments.
Problem
The Session._build_url() method could not parse IPv6 addresses in bracket notation (RFC 3986 format). The existing regex pattern only matched
IPv4 addresses and hostnames, causing URLs like http://[2a05:d018:1961:ba00:ff5b:37ba:20c7:726a]:5985/wsman to fail parsing.
Solution
Implemented dual-pattern regex matching:
Changes
Test Coverage
Validation
Fixes #400