Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename playground to best-practices #127

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Rename playground to best-practices #127

merged 1 commit into from
Dec 4, 2024

Conversation

cunla
Copy link
Member

@cunla cunla commented Dec 3, 2024

No description provided.

Copy link

github-actions bot commented Dec 3, 2024

Terraform plan in terraform
With var files: terraform/production/org.tfvars terraform/production/repositories.tfvars
With variables: github_token = (sensitive value)

Plan: 0 to add, 3 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place

Terraform will perform the following actions:

  # github_team.repo_admin_team["best-practices"] will be updated in-place
!~  resource "github_team" "repo_admin_team" {
!~      description               = "Admin team for the django-commons-playground repository" -> "Admin team for the best-practices repository"
        id                        = "9757650"
        name                      = "best-practices-admins"
#        (10 unchanged attributes hidden)
    }

  # github_team.repo_committer_team["best-practices"] will be updated in-place
!~  resource "github_team" "repo_committer_team" {
!~      description               = "Committers team for the django-commons-playground repository" -> "Committers team for the best-practices repository"
        id                        = "9757668"
        name                      = "best-practices-committers"
#        (10 unchanged attributes hidden)
    }

  # github_team.repo_team["best-practices"] will be updated in-place
!~  resource "github_team" "repo_team" {
!~      description               = "Main team for the django-commons-playground repository" -> "Main team for the best-practices repository"
        id                        = "9757678"
        name                      = "best-practices"
#        (10 unchanged attributes hidden)
    }

Plan: 0 to add, 3 to change, 0 to destroy.

📝 Plan generated in Plan org changes and list them in a PR #52

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@tim-schilling
Copy link
Member

@cunla do we merge this and close #126?

@cunla
Copy link
Member Author

cunla commented Dec 4, 2024

@cunla do we merge this and close #126?

yes. I'll do it

@cunla cunla merged commit 55862a7 into main Dec 4, 2024
2 checks passed
@cunla cunla deleted the rename-playground-repo branch December 4, 2024 00:49
@tim-schilling
Copy link
Member

Thank you for handling that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants