-
Notifications
You must be signed in to change notification settings - Fork 301
Django 3.2 support #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 3.2 support #908
Conversation
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 58 58
Lines 3101 3101
=======================================
Hits 3029 3029
Misses 72 72 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I have added missing changelog entry.
Concerning debug toolbar: Work is in progress (#468) to separate tests and example app so debug toolbar is not used within tests - so for now I am fine that we ignore this deprecation warning.
Thank you. I left out the changelog update as I didn't know what format you used for yet-to-be released changes. |
is there a release for this? |
No, not yet. See #911 about this as well. |
Fixes #907
Description of the Change
Allows the library to be used with Django 3.2.
I had to ignore a warning from Django related to django-debug-toolbar in order for tests to pass. I felt like that probably would be an acceptable way to work around it the deprecation warning without blocking this library to be upgraded to support Django 3.2, especially since the library doesn't depend directly on django-debug-toolbar.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS