Skip to content

Django 3.2 support #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Django 3.2 support #908

merged 7 commits into from
Apr 7, 2021

Conversation

Tenzer
Copy link
Contributor

@Tenzer Tenzer commented Apr 7, 2021

Fixes #907

Description of the Change

Allows the library to be used with Django 3.2.

I had to ignore a warning from Django related to django-debug-toolbar in order for tests to pass. I felt like that probably would be an acceptable way to work around it the deprecation warning without blocking this library to be upgraded to support Django 3.2, especially since the library doesn't depend directly on django-debug-toolbar.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #908 (f132897) into master (0892e3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #908   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          58       58           
  Lines        3101     3101           
=======================================
  Hits         3029     3029           
  Misses         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0892e3a...f132897. Read the comment docs.

@Tenzer Tenzer mentioned this pull request Apr 7, 2021
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I have added missing changelog entry.

Concerning debug toolbar: Work is in progress (#468) to separate tests and example app so debug toolbar is not used within tests - so for now I am fine that we ignore this deprecation warning.

@sliverc sliverc merged commit 51daed1 into django-json-api:master Apr 7, 2021
@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 7, 2021

Thank you. I left out the changelog update as I didn't know what format you used for yet-to-be released changes.

@simkimsia
Copy link

is there a release for this?

@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 14, 2021

No, not yet. See #911 about this as well.

@simkimsia
Copy link

@Tenzer copy that. I subscribed to #911

@sliverc sliverc mentioned this pull request May 2, 2021
5 tasks
@sliverc sliverc mentioned this pull request Oct 22, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Django 3.2 compatibility
4 participants