Handled pre-releases when setting previous release as end of life.#2018
Merged
bmispelon merged 1 commit intodjango:mainfrom Apr 17, 2025
Merged
Handled pre-releases when setting previous release as end of life.#2018bmispelon merged 1 commit intodjango:mainfrom
bmispelon merged 1 commit intodjango:mainfrom
Conversation
sarahboyce
force-pushed
the
eol_previous_release
branch
from
72bb322 to
aa9e38c
Compare
bmispelon
approved these changes
Apr 17, 2025
Member
bmispelon
left a comment
bmispelon
left a comment
There was a problem hiding this comment.
I like this! The code is easy to read and the added tests show that it's working as intended.
I just left a suggestion, but that's for something that was already in the original code. I figure since we're touching it we may as well tidy up as we go 🧹
Nice work! 🎸
| elif self.status == "f" and self.micro > 0: | ||
| previous_release_kwargs["micro"] = self.micro - 1 | ||
|
|
||
| self.__class__.objects.filter(**previous_release_kwargs).update( |
Member
There was a problem hiding this comment.
I don't understand why we can't use the simpler form:
Suggested change
| self.__class__.objects.filter(**previous_release_kwargs).update( | |
| self.filter(**previous_release_kwargs).update( |
Contributor
Author
There was a problem hiding this comment.
self here is a model instance I believe so you can't access filter or objects
Member
There was a problem hiding this comment.
Doh 🤦🏻 (for some reason I thought we were on the queryset, not the model)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2016