Conversation
Owner
Author
|
@zeha or @aramprice, just looking for a quick check, how's it look? |
aramprice
approved these changes
Dec 6, 2025
aramprice
left a comment
aramprice
left a comment
There was a problem hiding this comment.
looks good to me, thanks for poking at this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Ruby 3.4. and later, I am seeing
warning: literal string will be frozen in the futurefor a couple places where I'm providing human readable strings for mount properties.This PR basically just replaces instances of
<<with+=to avoid these warnings. As these are relatively short and simple strings, the effect should be negligible.I've also updated the test task to run with warnings on by default.