Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Remove some redundant function calls #463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove some redundant function calls #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dwl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1804,9 +1804,6 @@ outputmgrapplyortest(struct wlr_output_configuration_v1 *config, int test)
else
wlr_output_configuration_v1_send_failed(config);
wlr_output_configuration_v1_destroy(config);

/* TODO: use a wrapper function? */
updatemons(NULL, NULL);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is actually needed. While testing it turned out that without this call some changes didn't apply.

BTW, it can be replaced with wl_signal_emit_mutable(&output_layout->events.change, output_layout);

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Do you remember what kind of changes didn't apply, and are we sure it's not a wlroots bug? These lines came from cb01ce9, in case that helps jog your memory.

(I don't have an external on me right now, so I had to test using the wl backend instead of drm.)

}

void
Expand Down