Skip to content

Conversation

@Emmankoko
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Emmankoko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22102"

@Emmankoko Emmankoko changed the title provide D builtins implementations for C numeric operations provide implementations for C numeric operations builtins Nov 15, 2025
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doublecheck that none of these are #defined in importc.h

@dkorpel
Copy link
Contributor

dkorpel commented Nov 15, 2025

Looks good! Have you tried compiling sdl3 with this change?

@Emmankoko
Copy link
Contributor Author

Just doublecheck that none of these are #defined in importc.h

noted !

@Emmankoko
Copy link
Contributor Author

Emmankoko commented Nov 16, 2025

Looks good! Have you tried compiling sdl3 with this change?

joe@Emmanuels-MacBook-Pro dmd % ./generated/osx/release/64/dmd see.d -L-lSDL3 -P-I/usr/local/opt/sdl3/include/SDL3/ zup.c
joe@Emmanuels-MacBook-Pro dmd % ./generated/osx/release/64/dmd see.d -L-lSDL3 -P-I/usr/local/opt/sdl3/include/SDL3/ zup.c
joe@Emmanuels-MacBook-Pro dmd % 

locally testing them. sdl compiles now on macOS

@thewilsonator
Copy link
Contributor

Is this good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants