Avoid exposing compiler-generated lambda identifiers in instantiation traces - #23837
Closed
usefahmed07 wants to merge 1 commit into
Closed
usefahmed07 wants to merge 1 commit into
usefahmed07 wants to merge 1 commit into
Conversation
… traces Follow-up to dlang#20261 / dlang#23835. The 'instantiated from here' supplemental error line, printed by TemplateInstance.printInstantiationTrace, still exposed the internal compiler-generated identifier for lambda templates Added a check in printInstantiationTrace: when a TemplateInstance's tempdecl wraps a FuncLiteralDeclaration (i.e. it originates from a lambda), the trace now reports it simply as 'lambda function' instead of the internal name, across all three trace-printing code paths (normal, collapsed-recursion, and too-deep). Updated existing fail_compilation tests that asserted on the old internal identifier.
DMD perf check
All measurements
a2d4abe vs merge-base e1a45b8 · about these metrics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23836
Follow-up to #20261 (fixed in #23835)