Make dirEntries more robust to changes of the working directory
#10706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @0xEAB! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10706" |
|
Does not use |
0xEAB
force-pushed
the
more-robust-dirEntries
branch
from
ae555fb to
5b52a2a
Compare
If this passes CI, we can keep it in, I suppose.
0xEAB
force-pushed
the
more-robust-dirEntries
branch
from
5b52a2a to
0cf64dd
Compare
|
ping me when this is good to go. |
|
I’ve hinted it in #10718 (comment) already; I’m looking forward to replace this PR, too. I’m currently working on the Windows version of a more easily digestible replacement to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the situation with #9584 in a backwards compatible fashion.
Fixing the case where a
DirEntryis implicitly converted to a relative path in form of astringwould introduce a breaking change – as far as I can tell at least.This revises the “bad” parts of #10666/#6125 – my previous PR and the other PR that it attempted to salvage, respectively.
Also inherits the “good” parts of #10669 which is another PR from me that couldn’t keep up with its goal of actually closing the bug report.