First code submission for MVC Pipeline #6749

donker · 2025-10-03T13:34:00Z

This PR is a first submission of the work of the MVC Pipeline team to bring the main project up to date with what has been developed in a forked repo.

…tomizations for the MVC pipeline.

Fix layout issue

- fix case

client dependecy for mvc (because it not exist in nuget)

Mvcpl2

donker · 2025-10-14T19:18:18Z

@bdukes @donker I believe we discussed that this is just a reset PR and initial review, as it is into their branch correct? High level review only?

Yes. This is what we discussed in an earlier meeting to have the first code submission a proper PR.

valadas

Ok, I found a bit of time and reviewed about the first 1/4 of this PR.

I think we should bring this PR to the minimal viable MVC working state (even if incomplete) just with the minimum to load up an mvc theme and module.

MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of this PR was to have a baseline so that we can review smaller additions in an easier way.

Other than that, it does not have to be in this PR but I would like that we add our stylecop rules to the new projects to enforce our coding standards on this huge amount of new code.

I'll try to review some more the next coming days.

Thanks @sachatrauwaen for this huge contribution!

valadas · 2025-10-15T06:37:23Z

DNN Platform/DotNetNuke.Web.MvcPipeline/Controllers/ModuleSettingsController.cs

+        private void CheckPermissions()
+        {
+            // Verify that the current user has access to edit this module
+            if (!ModulePermissionController.HasModuleAccess(SecurityAccessLevel.Edit, "MANAGE", this.Module))
+            {
+                if (!(this.IsSharedViewOnly() && TabPermissionController.CanAddContentToPage()))
+                {
+                    throw new UnauthorizedAccessException("Access denied");
+                }
+            }
+        }


This one hurts my brain a bit specially since it relates to permissions and should be very clear and intuitive.

Suggested change

private void CheckPermissions()

{

// Verify that the current user has access to edit this module

if (!ModulePermissionController.HasModuleAccess(SecurityAccessLevel.Edit, "MANAGE", this.Module))

{

if (!(this.IsSharedViewOnly() && TabPermissionController.CanAddContentToPage()))

{

throw new UnauthorizedAccessException("Access denied");

}

}

}

private void CheckPermissions()

{

// Verify that the current user has access to edit this module

if (ModulePermissionController.HasModuleAccess(SecurityAccessLevel.Edit, "MANAGE", this.Module))

{

return;

}

if (this.IsSharedViewOnly() && TabPermissionController.CanAddContentToPage())

{

return;

}

throw new UnauthorizedAccessException("Access denied");

}

Which then begs the question, should we allow the module settings control to be viewed for a shared module to content editors? It looks wrong to me unless I am missing something.

to simplify, module settings stuff is removed from the pr, because actually out of scope of mvc pipeline

valadas · 2025-10-15T06:48:00Z

DNN Platform/DotNetNuke.Web.MvcPipeline/Controllers/ModuleSettingsViewController.cs

+            }
+        }
+
+        private void CheckPermissions()


Same concern here as my previous comment on the similar code in ModuleSettingsController.cs

Also what is the difference between ModuleSettingscontroller and MOduleSettingsViewController.cs?

to simplify, module settings stuff is removed from the pr, because actually out of scope of mvc pipeline

valadas · 2025-10-15T06:50:41Z

DNN Platform/DotNetNuke.Web.MvcPipeline/Controllers/ModuleViewControllerBase.cs

+        public bool EditMode
+        {
+            get
+            {
+                return this.ModuleContext.EditMode;
+            }
+        }
+
+        public bool IsEditable
+        {
+            get
+            {
+                return this.ModuleContext.IsEditable;
+            }
+        }
+
+        public int PortalId
+        {
+            get
+            {
+                return this.ModuleContext.PortalId;
+            }
+        }
+
+        public int TabId
+        {
+            get
+            {
+                return this.ModuleContext.TabId;
+            }
+        }


If we expose ModuleContext, do we need to also expose those properties, could we make the API surface simper by limiting the redundant properties?

It was inspirid from PortalModuleBase. But, yes i can make the API surface simper.
I can for exemple, inspire from DnnController from mvc modules witch expose : ModuleContext, PortalSettings, ActiveModule, ActivePage and User

valadas · 2025-10-15T06:51:31Z

DNN Platform/DotNetNuke.Web.MvcPipeline/Controllers/ModuleViewControllerBase.cs

+        public UserInfo UserInfo
+        {
+            get
+            {
+                return this.PortalSettings.UserInfo;
+            }
+        }
+
+        public int UserId
+        {
+            get
+            {
+                return this.PortalSettings.UserId;
+            }
+        }
+
+        public PortalAliasInfo PortalAlias
+        {
+            get
+            {
+                return this.PortalSettings.PortalAlias;
+            }
+        }


Same for PortalSetings which is already exposed, do we need those properties also exposed?

It was inspirid from PortalModuleBase. But, yes i can make the API surface simper.
I can for exemple, inspire from DnnController from mvc modules witch expose : ModuleContext, PortalSettings, ActiveModule, ActivePage and User

valadas · 2025-10-15T06:58:03Z

DNN Platform/DotNetNuke.Web.MvcPipeline/Extensions/StartupExtensions.cs

+                            type is { IsClass: true, IsAbstract: false });
+            foreach (var controller in mvcControllerTypes)
+            {
+                services.TryAddTransient(controller);


Should this be scoped @bdukes ?

We're using scoped for web API controllers, but transient for MVC controllers:

Dnn.Platform/DNN Platform/DotNetNuke.Web/Api/Extensions/StartupExtensions.cs

Line 33 in 3ce2474

services.TryAddScoped(controller);

Dnn.Platform/DNN Platform/DotNetNuke.Web.Mvc/Extensions/StartupExtensions.cs

Line 33 in 3ce2474

services.TryAddTransient(controller);

Scoped it probably the right way

sachatrauwaen · 2025-10-15T15:16:15Z

MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of this PR was to have a baseline so that we can review smaller additions in an easier way.

There an separate PR for CSP on the develop branch.

But removing it from this PR needs to remove a lot of code.
The idee is to replace the CSP project of this PR with the PR on develop when the PR is merged in develop.

Actually we heave a lot of sync issues between the differnt PR's.
I don'tknow the best way. So your advice is welcome.

valadas · 2025-10-15T20:16:05Z

MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of this PR was to have a baseline so that we can review smaller additions in an easier way.

There an separate PR for CSP on the develop branch.

But removing it from this PR needs to remove a lot of code. The idee is to replace the CSP project of this PR with the PR on develop when the PR is merged in develop.

Actually we heave a lot of sync issues between the differnt PR's. I don'tknow the best way. So your advice is welcome.

So if that is the case, we need to review/agree on the CSP one first before spending too much time reviewing this one...

valadas · 2025-10-15T20:16:11Z

MVC Pipeline and CSP are 2 big ticket items and bringing both in the same PR makes putthing this in a reviewable state hard IMO. The goal of this PR was to have a baseline so that we can review smaller additions in an easier way.

There an separate PR for CSP on the develop branch.

But removing it from this PR needs to remove a lot of code. The idee is to replace the CSP project of this PR with the PR on develop when the PR is merged in develop.

Actually we heave a lot of sync issues between the differnt PR's. I don'tknow the best way. So your advice is welcome.

So if that is the case, we need to review/agree on the CSP one first before spending too much time reviewing this one...

This reverts commit e07308a.

…auwaen/Dnn.Platform into feature/mvc-pipeline-old # Conflicts: # mvc-pipeline.md

…auwaen/Dnn.Platform into feature/mvc-pipeline-old

… and is actually not working

Remove module settings, because actually out of scope

…pipeline-old

sachatrauwaen · 2025-10-22T13:20:01Z

To simplify the review

CSP is removed from this branch (i have just leaved some comments for later integration)
remove module settings stuff, because actually out of scope of mvc pipeline

sachatrauwaen · 2025-10-22T13:25:09Z

My suggestion is

before reviewing "First code submission for MVC Pipeline", merge this PRs without review
PRs are inter dependend and replace a lot of code and are on this branch
So after you will review the whole with a cleaner and more definitive view

MVC pipeline - Module control — Type: Feature #6700
MVC pipeline popups #6723
MVC pipeline (routing / settings) #6721
MVC pipeline - module actions #6725

donker and others added 30 commits March 20, 2025 11:36

Initial port of MVC-PAGE branch to DNN 10

96b3954

Fixes

806a567

With previous

18dda02

More moving stuff around

2b93b83

Moving more classes to Mvc Pipeline project

e66429e

Add build file

195b407

Move MVC skin detection to separate class

192a1fe

Added the controllers for the core website

ed9dfad

NewDDRMenu project which forks the original DDR menu project with cus…

0b39bb2

…tomizations for the MVC pipeline.

Rewire the way we detect MVC skins

23b6b13

Ability to replace the urlrewriter

825ae25

Changes that hard wired to ascx files for the skin

26a4165

Revert changes to core project

261a156

Merge branch 'release/10.0.0' into MVCPL

9ec0a3d

Rolling back mvc skin detection to what it was previously

44c90c7

Fixing routing

bcba2c6

Fix layout issue

6b1f317

Merge pull request #1 from donker/fix1

4700236

Fix layout issue

- avoid dublicate key error with standard DDRMENU

af884e5

- fix case

client dependecy for mvc (because it not exist in nuget)

78bcb42

Merge pull request #3 from sachatrauwaen/mvcppl1

419c044

client dependecy for mvc (because it not exist in nuget)

restrore use of clientdependency.core.mvc

5e3b2d4

add use of css variables

d17225a

add support for report-to

e903cda

update web.config for mvc

55308ab

port all what is needed to run from dnn9 version

e107bd4

first part of the html module : view control

c91f68a

Merge pull request #4 from sachatrauwaen/mvcpl2

09c4c04

Mvcpl2

use dnn10 default.css

4aae3e8

make edit in mvc work again

0fd3b47

sachatrauwaen and others added 3 commits October 14, 2025 15:13

fix test of DnnController

863cbb7

Fix tests on DnnController.cs

7be534e

Fix blank lines in DnnController.cs

526412b

remove blank linesDnnController.cs

9ab7cae

valadas reviewed Oct 15, 2025

View reviewed changes

sachatrauwaen and others added 18 commits October 17, 2025 20:19

mvc pipeline doc

fda5223

doc

f6231bc

modified proposition

ee09648

modified proposition

626e5a0

fix layout

e07308a

Revert "fix layout"

4a18e30

This reverts commit e07308a.

Merge branch 'feature/mvc-pipeline-old' of https://github.com/sachatr…

e007e36

…auwaen/Dnn.Platform into feature/mvc-pipeline-old # Conflicts: # mvc-pipeline.md

fix layout

a3d5c18

fix layout

74b12d4

fix text

4bf447e

Merge branch 'feature/mvc-pipeline-old' of https://github.com/sachatr…

d89fbb8

…auwaen/Dnn.Platform into feature/mvc-pipeline-old

fix text

0f32c9a

Fix typos in mvc-pipeline.md

6a24f3a

blog post

567c571

rremove docs from this branch

b9fa629

Remove module settings, because actually out of scope of MVC pipeline…

039633e

… and is actually not working

Remove CSP from mvc pipeline (it will be integrated later)

ac6941f

Remove module settings, because actually out of scope

Merge branch 'dnnsoftware:feature/mvc-pipeline-old' into feature/mvc-…

f522728

…pipeline-old

remove CSP from html module and module settings for mvc pipeline

12e1d64

Uh oh!

Uh oh!

First code submission for MVC Pipeline #6749

Are you sure you want to change the base?

First code submission for MVC Pipeline #6749

Uh oh!

Conversation

donker commented Oct 3, 2025

Uh oh!

donker commented Oct 14, 2025

Uh oh!

valadas left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sachatrauwaen commented Oct 15, 2025

Uh oh!

valadas commented Oct 15, 2025

Uh oh!

valadas commented Oct 15, 2025

Uh oh!

sachatrauwaen commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sachatrauwaen commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sachatrauwaen commented Oct 22, 2025 •

edited

Loading

sachatrauwaen commented Oct 22, 2025 •

edited

Loading