-
Notifications
You must be signed in to change notification settings - Fork 33
Document registrant-changes endpoints #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
While working on this, I also noticed that this endpoints are being used currently by customers, this can be seen on our DD logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/dnsimple/dnsimple-developer/pull/895/files#diff-acb3aa7e874a0877690713ea6cf11d484e41833e1c2f4112f0170a802c1e3d9bR11-R15 seems to say two different things: "change the registrant contact for a registered domain" and then in the info "Registrant changes allow you update the registrant information for a domain". I believe the info statement muddies the intent of the API rather than clarifies it, assuming that this endpoint behaves as I expect, which is to change the registrant contact from one contact to another.
@aeden may I get another look? |
This PR introduces a new documentation page for registrant-changes API endpoints.
Fixes #894
🔍 QA
📋 Deployment Pre/Post tasks