-
Notifications
You must be signed in to change notification settings - Fork 1
feat: initial api & client implementation #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
945e7bd
feat: idea for api design
edeandrea de7cec5
Merge branch 'main' into api-design
edeandrea 2760a89
refactor: Fix up build plugin & dependencies structure
edeandrea 8f88ebe
feat: idea for api design
edeandrea 1b3c2d9
feat: idea for api design
edeandrea cf3b812
feat: idea for api design
edeandrea 01de8c7
feat: idea for api design
edeandrea 1ab7efd
feat: idea for api design
edeandrea 5ffe7c9
Merge branch 'main' into api-design
edeandrea 4468804
feat: idea for api design
edeandrea cc57513
feat: idea for api design
edeandrea e2dbccf
feat: idea for api design
edeandrea 9629068
feat: idea for api design
edeandrea dfa6755
refactor docling-api into docling-serve-api
edeandrea db96e07
refactor docling-api into docling-serve-api
edeandrea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
127 changes: 0 additions & 127 deletions
127
api/src/main/java/ai/docling/api/convert/request/ConvertDocumentRequest.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the idea is to possibly have a
docling-clientmodule in the future using Docling directly (no Docling Serve like indocling-serve-client), I wonder if we should similarly have adocling-serve-apimodule (for all the code currently in docling-api) and adocling-apimodule that would only include the Docling core APIs (e.g.Document). In alternative, single module, but two sub packages (core,serve)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I've totally changed this comment after thinking about it a bit.
That might not be a bad idea. We can just rename docling-api to docling-serve-api for now. We can build a placeholder for docling-api (or introduce it later on).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasVitale i've gone ahead and restructured this. I created a new top-level folder
docling-serveand moved bothdocling-serve-api(formerlydocling-api) anddocling-serve-clientinto this folder.I also changed the package structure for
docling-serve-api(formerlydocling-api) toai.docling.api.serve(formerlyai.docling.api).See dfa6755