Skip to content

Conversation

@sarahec
Copy link

@sarahec sarahec commented Oct 9, 2025

This fixes #170

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

DCO Check Passed

Thanks @sarahec, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Oct 9, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Enforce conventional commit

This rule is failing.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@sarahec sarahec changed the title Make build and dev dependencies optional Fix: Make build and dev dependencies optional Oct 9, 2025
@sarahec sarahec force-pushed the docling-parse-deps branch from f0e9471 to e85dfd4 Compare October 9, 2025 23:16
@PeterStaar-IBM
Copy link
Contributor

@sarahec What does this solve?

@sarahec
Copy link
Author

sarahec commented Oct 11, 2025

@sarahec What does this solve?

Look at #170. The build and dev dependency groups are getting merged into the final product; this marks them correctly as optional as they're only meant to be used during development. (Notice that in the workflow scripts you're explicitly excluding cmake and the other build-only tools which shouldn't have been there in the first place.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in pyproject.toml leads to cmake, etc. being included in the resulting package

2 participants