feat(deps): Moved polyfactory to an extra
#2484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ DCO Check Passed Thanks @jamesbraza, all your commits are properly signed off. 🎉 |
|
Related Documentation Checked 3 published document(s). No updates required. How did I do? Any feedback? |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, James Braza <[email protected]>, hereby add my Signed-off-by to this commit: ab90b83 I, James Braza <[email protected]>, hereby add my Signed-off-by to this commit: d8d1ec9 Signed-off-by: James Braza <[email protected]>
dolfim-ibm
requested changes
Oct 17, 2025
There was a problem hiding this comment.
See my comments in the issue #2482 (comment). I don't see a reason for making the dependency optional, and the proposed PR is not providing an alternative implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2482