[Translatable] Add a way to ease bulk translations with default locale#3050
Open
Florian-Schoenherr wants to merge 3 commits into
Open
[Translatable] Add a way to ease bulk translations with default locale#3050Florian-Schoenherr wants to merge 3 commits into
Florian-Schoenherr wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See doc/translatable.md.
Before this change, when you saved all locales translation values (including the default one) only via personal translations, the main entity's field was filled pretty randomly. Either with the default locale value, or depending on exact setup with NULL or the default empty value.
Our usecase is a simple admin UI which has a way of specifying all translations at once.
My other hunch was that the previous behavior was a bug for personal translations which does not happen with the ext_translation table, but idk. Because it seems odd that Gedmo won't sync back if I add a new entity and persist only its translations.
Yes this is a 100 line change, but some of that is the
skipcheck moving down and a bunch of comments.