Change MySQL bool mapping from TINYINT(1) to TINYINT #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since 8.0 Mysql throws "1681 [HY000] Integer display width is deprecated and will be removed in a future release." when integer column with display with is created - this change is backwards compatible (does not trigger column type update migration)
|
Would this break our introspection of boolean columns? You've also changed the behavior for MariaDB. Was that intended? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8.0 MySQL throws whis warning "1681 [HY000] Integer display width is deprecated and will be removed in a future release." when integer column with display width is created
This change is backwards compatible and can be merged into all active branches (does not trigger column type update migration)