fix: dont expand query on regular named arguments

[shyim]

Q	A
Type	bug/
Fixed issues

Summary

The SQLParser is always a bottleneck in Shopware Projects. I am optimizing it by preparing our queries so they do not use ArrayParameterType. While doing that, I discovered that it does that when any named parameter is set. Which is not necessary on MySQL. IDK about other.

Here the diff for our queries: (removing arrayparameters completely will remove the ~200ms on any req)

[morozov]

This is similar to #3744.

While doing that, I discovered that it does that when any named parameter is set. Which is not necessary on MySQL.

If you're saying that the conversion of named parameters to positional is unnecessary for MySQL, this is not entirely true. It's unnecessary for pdo_mysql (as well for any other PDO drivers) but is necessary for mysqli.

A proper fix is to have the DBAL driver (not the wrapper) convert the parameters to the format that the underlying driver understands, if necessary.

[shyim]

You mean move the method needsArrayParameterConversion kinda to the driver class and toggle it there?

[morozov]

You mean move the method needsArrayParameterConversion kinda to the driver class and toggle it there?

No, have the driver itself accept the parameters as is and do the conversion if necessary.