Fix parsing quoted table name on SQLite #6600
Open
+42
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
sqlite-quoted-table-comment
branch
from
14c384f
to
3cf60fc
Compare
The pattern used in parseTableCommentFromSQL() was invalid. It would wrap the value returned by quoteSingleIdentifier() in another set of quotes. It would only work for unquoted table names, which would be handled but the pattern that matches an unquoted name.
morozov
force-pushed
the
sqlite-quoted-table-comment
branch
from
09752dc
to
395269a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was discovered during the work on #6589. The pattern used in
parseTableCommentFromSQL()was invalid. It would wrap the value returned byquoteSingleIdentifier()in another set of quotes. It would only work for unquoted table names, which would be handled but the other pattern – the one that matches an unquoted name.