Change lock SQL helper methods to protected#12363
Open
ruudk wants to merge 1 commit into
Open
Conversation
This allows to extend `SingleSelectSqlFinalizer` and then overwrite some of the lock SQL's. In my case, I want to use `SKIP LOCKED` in MySQL
Contributor
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Contributor
Author
|
I'd like this to be merged Who can help me out? Maybe @derrabus? |
Member
|
An internal trait is clearly not an intended extension point. I really don't think, we should do that. |
greg0ire
requested changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to extend
SingleSelectSqlFinalizerand then overwrite some of the lock SQL's.In my case, I want to use
SKIP LOCKEDin MySQL